[ECS-Plugin] Document for user#6712
Conversation
Signed-off-by: Hoang Ngo <adlehoang118@gmail.com>
Signed-off-by: Hoang Ngo <adlehoang118@gmail.com>
Signed-off-by: Hoang Ngo <adlehoang118@gmail.com>
Signed-off-by: Hoang Ngo <adlehoang118@gmail.com>
Signed-off-by: Hoang Ngo <adlehoang118@gmail.com>
Signed-off-by: Hoang Ngo <adlehoang118@gmail.com>
Signed-off-by: Hoang Ngo <adlehoang118@gmail.com>
…on file" Signed-off-by: Hoang Ngo <adlehoang118@gmail.com>
Signed-off-by: Hoang Ngo <adlehoang118@gmail.com>
Signed-off-by: Hoang Ngo <adlehoang118@gmail.com>
7ca28b5 to
c93da0a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6712 +/- ##
==========================================
+ Coverage 29.48% 37.92% +8.44%
==========================================
Files 593 61 -532
Lines 63440 5331 -58109
==========================================
- Hits 18706 2022 -16684
+ Misses 43289 3193 -40096
+ Partials 1445 116 -1329
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
eeshaanSA
left a comment
There was a problem hiding this comment.
Hello @armistcxy, is there no way to split this into multiple PRs? This would ease the reviewers, and eventually result in a faster merge.
|
Hi @eeshaanSA, really sorry for this big PR. I think I can't split this into multiple PRs. You can review only the section you think important, I have noted the outline above Also use |
For this, I will have to checkout your PR or serve it on GitHub Codespaces (We have access to CoPilot Enterprise as Maintainers). Please give me sometime, I will try reviewing it. |
What this PR does: Adds user documentation for the ECS plugin (
docs-v1.0.x) covering:ECS_PRIMARY_ROLLOUT,ECS_CANARY_ROLLOUT,ECS_TRAFFIC_ROUTING,ECS_CANARY_CLEAN,ECS_ROLLBACKWhy we need it:
Which issue(s) this PR fixes:
Fixes #6443
Does this PR introduce a user-facing change?: